Change all calls to TrackExtra::add to TrackExtra::setHits

[Dr15Jones]

TrackExtra::add was removed from the TrackExtra api.
Calls TrackExtra::add required to caller to pass edm::Ref's which
come from sequential entries in the same container. The callers always
created a temporary edm::Ref which was then discarded.
The TrackExtra::setHits API better enforces the requirements by taking
an edm:RefProd to the container and then a starting index and number of
entries into that container for the hits. Not only is setHits safer
than calling add it is also faster.

TrackExtra::add had to go away anway because of work being done in
the framework which will no longer allow an edm::RefProd to be constructed
from an edm::Ref.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Change all calls to TrackExtra::add to TrackExtra::setHits

It involves the following packages:

CommonTools/RecoAlgos
DataFormats/TrackReco
FastSimulation/Tracking
RecoEgamma/EgammaPhotonProducers
RecoHI/HiTracking
RecoMuon/L3MuonProducer
RecoMuon/TrackingTools
RecoPixelVertexing/PixelLowPtUtilities
RecoPixelVertexing/PixelTrackFitting
RecoTracker/FinalTrackSelectors
RecoTracker/TrackProducer
SimMuon/MCTruth

@civanch, @nclopezo, @lveldere, @cvuosalo, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @rappoccio, @abbiendi, @Martin-Grunewald, @lgray, @venturia, @battibass, @makortel, @dgulhan, @cerati, @trocino, @rociovilar, @Sam-Harper, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @richard-cms, @echapon, @mandrenguyen, @jazzitup, @appeltel, @ahinzmann, @yenjie, @kurtejung, @gpetruc, @matt-komm, @yetkinyilmaz, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 6ef647f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7246/1966/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7246/1966/summary.html

[civanch]

+1

[slava77]

+1

for #7246 6ef647f
tested also with longer tests in CMSSW_7_4_0_pre3 /test area sign489/, no changes, as in jenkins

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.