Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM/L1TMonitor: definite static const int members #7249

Merged
merged 1 commit into from
Jan 19, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jan 17, 2015

The patch resolves issue with Clang compiler.

N3690 (should be C++11 standard), 9.4.2/3

...
The member shall still be defined in a namespace scope if it
is odr-used (3.2) in the program and the namespace scope definition
shall not contain an initializer.

9.4.2/3 talks about how const static data members are being handled.

Also standard says that no diagnostic is required by compiler.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

The patch resolves issue with Clang compiler.

N3690 (should be C++11 standard), 9.4.2/3

    ...
    The member shall still be defined in a namespace scope if it
    is odr-used (3.2) in the program and the namespace scope definition
    shall not contain an initializer.

9.4.2/4 talks about how `const static` data members are being handled.

Also standard says that no diagnostic is required by compiler.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_4_X.

DQM/L1TMonitor: definite static const int members

It involves the following packages:

DQM/L1TMonitor

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Jan 19, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 19, 2015
DQM/L1TMonitor: definite static const int members
@cmsbuild cmsbuild merged commit 4ca85f9 into cms-sw:CMSSW_7_4_X Jan 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants