Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mssing link dependency and fix checksum #7291

Merged
merged 1 commit into from
Jan 21, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jan 20, 2015

If feasible, do not merge this pull request info CMSSW_7_4_ROOT6_X, as this needs to be fixed separately there.
In ROOT 5.34, and ROOT 6, checksums depend on the base class.
Because of a missing link dependency, DataFormats/ParticleFlowReco was built before DataFormats/TrajectorySeed.
Because of this, edmCheckClassVersion calculated the wrong checksum. The problem with edmClassVersion needs to be fixed separately, because the checksum it calculates can depend on build order of the packages.
This pull request supplies the missing dependency, and updates the checksum accordingly.
Please expedite this critical pull request, bypassing signatures if not signed in a timely manner.
However, do not bypass testing, comparisons, and all that!!

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_4_X.

Add mssing link dependency and fix checksum

It involves the following packages:

DataFormats/ParticleFlowReco

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@slava77
Copy link
Contributor

slava77 commented Jan 21, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jan 21, 2015

+1

for #7291 24fe51e

jenkins is ok: runs, no diffs

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 21, 2015
Add mssing link dependency and fix checksum
@cmsbuild cmsbuild merged commit 11df47d into cms-sw:CMSSW_7_4_X Jan 21, 2015
@wmtan wmtan deleted the AddMissingLinkDepenedency branch January 23, 2015 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants