-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mssing link dependency and fix checksum #7291
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_4_X. Add mssing link dependency and fix checksum It involves the following packages: DataFormats/ParticleFlowReco @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Add mssing link dependency and fix checksum
If feasible, do not merge this pull request info CMSSW_7_4_ROOT6_X, as this needs to be fixed separately there.
In ROOT 5.34, and ROOT 6, checksums depend on the base class.
Because of a missing link dependency, DataFormats/ParticleFlowReco was built before DataFormats/TrajectorySeed.
Because of this, edmCheckClassVersion calculated the wrong checksum. The problem with edmClassVersion needs to be fixed separately, because the checksum it calculates can depend on build order of the packages.
This pull request supplies the missing dependency, and updates the checksum accordingly.
Please expedite this critical pull request, bypassing signatures if not signed in a timely manner.
However, do not bypass testing, comparisons, and all that!!