-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove circular dependency and fix checksum for class reco::CATopJetTagInfo. #7298
Remove circular dependency and fix checksum for class reco::CATopJetTagInfo. #7298
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_4_X. Remove circular dependency and fix checksum for class reco::CATopJetTagInfo. It involves the following packages: CommonTools/RecoAlgos @perrotta, @cmsbuild, @nclopezo, @cvuosalo, @fwyzard, @Martin-Grunewald, @deguio, @slava77, @danduggan can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
…cksum Remove circular dependency and fix checksum for class reco::CATopJetTagInfo.
In ROOT 5.34, and ROOT 6, class checksums depend on the base class.
Because of a missing link dependency, edmCheckClassVersion calculated the wrong checksum for class reco::CATopJetTagInfo.
Unfortunately, adding the missing link dependency would create an explicit mutual dependency between packages DataFormats/JetReco and DataFormats/BTauReco.
This pull request moves the definition of this class from DataFormats/JetReco to DataFormats/BTauReco, breaking the cyclic dependency, and also fixes the checksum.
The problem with edmClassVersion needs to be fixed separately, because the checksum it calculates can depend on build order of the packages.
This pull request also adds missing link dependecies on DataFormats/BTauReco, which, while not technically necessary due to the fact that all member functions of CATopJetTagInfo are in-lined.
Nonetheless, it is bad practice to omit package link dependencies for this reason.
Please expedite this critical pull request, bypassing signatures if not signed in a timely manner.
However, do not bypass testing, comparisons, and all that!!