Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove circular dependency and fix checksum for class reco::CATopJetTagInfo. #7298

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jan 21, 2015

In ROOT 5.34, and ROOT 6, class checksums depend on the base class.
Because of a missing link dependency, edmCheckClassVersion calculated the wrong checksum for class reco::CATopJetTagInfo.
Unfortunately, adding the missing link dependency would create an explicit mutual dependency between packages DataFormats/JetReco and DataFormats/BTauReco.
This pull request moves the definition of this class from DataFormats/JetReco to DataFormats/BTauReco, breaking the cyclic dependency, and also fixes the checksum.
The problem with edmClassVersion needs to be fixed separately, because the checksum it calculates can depend on build order of the packages.
This pull request also adds missing link dependecies on DataFormats/BTauReco, which, while not technically necessary due to the fact that all member functions of CATopJetTagInfo are in-lined.
Nonetheless, it is bad practice to omit package link dependencies for this reason.
Please expedite this critical pull request, bypassing signatures if not signed in a timely manner.
However, do not bypass testing, comparisons, and all that!!

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_4_X.

Remove circular dependency and fix checksum for class reco::CATopJetTagInfo.

It involves the following packages:

CommonTools/RecoAlgos
DQM/Physics
DataFormats/BTauReco
DataFormats/JetReco
HLTrigger/JetMET
RecoJets/JetAlgorithms
RecoJets/JetProducers

@perrotta, @cmsbuild, @nclopezo, @cvuosalo, @fwyzard, @Martin-Grunewald, @deguio, @slava77, @danduggan can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @yslai, @acaudron, @TaiSakuma, @Martin-Grunewald, @ahinzmann, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@slava77
Copy link
Contributor

slava77 commented Jan 21, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@slava77
Copy link
Contributor

slava77 commented Jan 21, 2015

+1

for #7298 53f3aa2
jenkins compiles and runs OK .. (CATopJetTagInfo appear only in the PAT/miniAOD step)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 21, 2015
…cksum

Remove circular dependency and fix checksum for class reco::CATopJetTagInfo.
@cmsbuild cmsbuild merged commit e5c03a7 into cms-sw:CMSSW_7_4_X Jan 21, 2015
@wmtan wmtan deleted the RemoveCircularDependencyAndFixChecksum branch January 23, 2015 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants