Create Data Format for Phase2TrackerCluster1D

[thomaslenzi]

Added a new Data Format to describe the outer tracker clusters for Phase2.

[cmsbuild]

A new Pull Request was created by @thomaslenzi (Thomas Lenzi) for CMSSW_6_2_X_SLHC.

Create Data Format for Phase2TrackerCluster1D

It involves the following packages:

DataFormats/Phase2TrackerCluster1D

The following packages do not have a category, yet:

DataFormats/Phase2TrackerCluster1D

@cmsbuild, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[ghost]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 12ebecd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7305/2047/summary.html

[thomaslenzi]

In the last commit I anticipated possible reactions regarding the choice of using edm or edmNew. I changed the files to keep only edmNew related definitions.

[thomaslenzi]

Dear @Degano, @nclopezo, @fratnikov, @mark-grimes,
May I get some feedback on how I can make this PR go forward?
Thank you,
Thomas

[ghost]

@thomaslenzi we have a new package: DataFormats/Phase2TrackerCluster1D, first this must be assigned to one of the existing L2 categories. You can check them in cms-bot: https://github.com/cms-sw/cms-bot/blob/master/categories.py#L47. This is possibly (one of) the reason @mark-grimes didn't accept this PR yet.

[davidlange6]

Is for Reco
(this name is far too specific, but for development in 62xSLHC I don't have a strong reason to fix it now vs later)

On Feb 2, 2015, at 12:32 PM, Alessandro Degano notifications@github.com
wrote:

@thomaslenzi we have a new package: DataFormats/Phase2TrackerCluster1D, first this must be assigned to one of the existing L2 categories. You can check them in cms-bot: https://github.com/cms-sw/cms-bot/blob/master/categories.py#L47. This is possibly (one of) the reason @mark-grimes didn't accept this PR yet.

—
Reply to this email directly or view it on GitHub.

[thomaslenzi]

Hi @davidlange6,
I can rename the package to "Phase2TrackerCluster" if needed, but I don't think I can get less specific than this without bringing confusion in the different type of cluster data formats that exist (SiPixelClusters, SiStripClusters, ...).

[slava77]

Phase2TrackerCluster should be ok
we have a Phase2TrackerDigi so, some convention already

[thomaslenzi]

I renamed the package to "Phase2TrackerCluster", and rebased my branch to the latest IB to be in phase with the official CMSSW repository.

[cmsbuild]

Pull request #7305 was updated. @cmsbuild, @nclopezo can you please check and sign again.

[mark-grimes]

merge

Categorisation for the new package has been requested in cms-sw/cms-bot#310.

[thomaslenzi]

Thank you all for your comments and feedback!