Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

porting 2017 scenario in 74X : first round of changes #7312

Merged
merged 6 commits into from
Jan 26, 2015

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Jan 22, 2015

This PR is starting to port the 2017 scenario in 74X - this PR is not pretending having done all the work (far from that :-) ) , but this is to start it.
I have aligned cmsExtende2017 scenario with the last version of 62XSLHC.
I have added the missing xml files used int his scenario which were only in 62XSLHC.
The algorithm DDHCalEndcapModuleAlgo used in the new xml files is also ported.
Nothing used in any of the standard workflow for run1/run2 is touched.
@bsunanda : you may want to follow this as well

@boudoul
Copy link
Contributor Author

boudoul commented Jan 22, 2015

@mark-grimes FYI

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @boudoul (boudoul) for CMSSW_7_4_X.

porting 2017 scenario in 74X : first round of changes

It involves the following packages:

Geometry/CMSCommonData
Geometry/EcalCommonData
Geometry/HcalAlgo
Geometry/HcalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@ghost
Copy link

ghost commented Jan 22, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor

ianna commented Jan 26, 2015

+1

@boudoul - so far this does not affect current Hcal in 74x.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 26, 2015
porting 2017 scenario in 74X : first round of changes
@cmsbuild cmsbuild merged commit 443b0f6 into cms-sw:CMSSW_7_4_X Jan 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants