Fix some obscure code in TrackingTruthAccumulator (still functionally identical)

[mark-grimes]

This should be functionally identical to the original, just makes the code clearer.

The TrackingVertex constructor takes an EncodedEventId. Previously this section of code passed an EncodedTruthId which is a derived class, but with an additional parameter used as an object index. In this code the object index is given a dummy value, which anyway is inaccessible when the class is resolved to the EncodedEventId base class passed to the constructor. So I just removed the dummy value and passed the EncodedEventId directly which should make the intention of the code clearer. Also removed the comment that shows uncertainty about what the dummy parameter should be.

I wrote this section of code originally but I can't remember why an EncodedTruthId was ever used.

[cmsbuild]

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_4_X.

Fix some obscure code in TrackingTruthAccumulator (still functionally identical)

It involves the following packages:

SimGeneral/TrackingAnalysis

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@battibass, @makortel, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @cerati, @trocino, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

[civanch]

+1

[ghost]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

[cmsbuild]

+1
Tested at: 68e2746
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7318/2066/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7318/2066/summary.html