Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add file ECALAndHCALCaloJetLinker.cc #7399

Merged
merged 2 commits into from
Feb 2, 2015

Conversation

yongjiexin3
Copy link
Contributor

add a new file for ECal and HCal Linking named : ECALAndHCALCaloJetLinker.cc
which delete the |Ecal.Eta| > 2.5 cut.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @yongjiexin3 for CMSSW_7_4_X.

add file ECALAndHCALCaloJetLinker.cc

It involves the following packages:

RecoParticleFlow/PFProducer

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@bachtis
Copy link
Contributor

bachtis commented Jan 27, 2015

Hi ,Just to add: This is needed for an alternative Calo only reconstruction
at HLT showing big improvements at L2. This file is not used in offline reco
so no changes are expected to anything by its addition. Please merge this when possible since
we need it very soon in 74X

@slava77
Copy link
Contributor

slava77 commented Jan 27, 2015

please provide a configuration to test this feature.

@cmsbuild
Copy link
Contributor

Pull request #7399 was updated. @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please check and sign again.

@davidlange6
Copy link
Contributor

please test

@ghost
Copy link

ghost commented Jan 28, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Feb 2, 2015

+1

for #7399 14ec806
checked in CMSSW_7_4_0_pre6 /test area sign506 /

I used the supplied config and ran it in the reconstruction step after supplying regular reco inputs instead of hlt inputs. The code runs ok and takes about the same time as the regular particleFlowBlock and makes output of a similar size.
This is a good enough test at this point (the feature is not enabled currently).

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Feb 2, 2015
@cmsbuild cmsbuild merged commit 6579b5d into cms-sw:CMSSW_7_4_X Feb 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants