Made Reflection::solid a const member function #7436
Conversation
The static analyzer complained that a class which held a Reflection object by pointer was calling a non-const function, 'solid', of Reflection from a const function of the holding class. Since 'solid' never actually changed the state of a Reflection it was trivial to change to be const.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X. Made Reflection::solid a const member function It involves the following packages: DetectorDescription/Core @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks. |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. |
cmsbuild
added
comparison-pending
fully-signed
geometry-approved
tests-approved
and removed
fully-signed
geometry-approved
tests-started
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Made Reflection::solid a const member function
The static analyzer complained that a class which held a Reflection
object by pointer was calling a non-const function, 'solid', of
Reflection from a const function of the holding class. Since 'solid'
never actually changed the state of a Reflection it was trivial
to change to be const.