Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Geometry Cleanup #7443

Merged
merged 3 commits into from
Jan 30, 2015

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jan 29, 2015

  • Remove unneeded class
  • Cleanup package dependencies

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_7_4_X.

Validation Geometry Cleanup

It involves the following packages:

Validation/Geometry

@civanch, @Dr15Jones, @danduggan, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @deguio, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@ianna
Copy link
Contributor Author

ianna commented Jan 29, 2015

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Jan 30, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 30, 2015
@cmsbuild cmsbuild merged commit 28d504b into cms-sw:CMSSW_7_4_X Jan 30, 2015
@ianna ianna deleted the validation-geometry-cleanup branch October 26, 2015 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants