Implement postLS1 as an Era - tranche 1 #7456
Conversation
|
A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_4_X. Implement postLS1 as an Era - tranche 1 It involves the following packages: SLHCUpgradeSimulations/Configuration @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
comparison-available
pending-signatures
simulation-pending
tests-approved
and removed
tests-approved
labels
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Implement postLS1 as an Era - tranche 1
This is another instalment of a split up #6784, following on from #7419. This adds no functionality at all, just expands out all function calls of the
customiseRun2EraExtrascustomisation to individual commands (probably should have put this in with the first PR). There is a description of what this function is for on #7419.The advantage of this PR is to make the next pull requests easier to assess, since each one will have something added to the era and the corresponding line taken out of this function. It also serves as a "check list" of every command that still needs to be added to the era.
I've done diffs of the
edmConfigDumps for all 1320.0 steps before and after and absolutely nothing changes.There's not much point running any tests, none of the tests use the affected function. I did run 1320.0 however with
--customise SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1replaced with--era run2 --customise SLHCUpgradeSimulations/Configuration/postLS1Customs.customiseRun2EraExtrasto make sure I didn't make a stupid formatting mistake.