Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generators Fixes -- Fix decay pi0 after Tauola++ migration. #775

Merged
merged 1 commit into from Sep 14, 2013

Conversation

mkirsano
Copy link
Contributor

No description provided.

@mkirsano
Copy link
Contributor Author

Recover the code to decay pi0 after tauolapp (it was lost in January during the redesign). Add some tests.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mkirsano for CMSSW_7_0_X.

fix1_decay_tauolapp_pi0_sw7

It involves the following packages:

GeneratorInterface/Pythia8Interface

@vciulli can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@nclopezo
Copy link
Contributor

Hi,

I ran the usual tests on top of CMSSW_7_0_X_2013-09-11-0200, all tests passed:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/450/console

you can see the artifacts here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/450

if(icategories[0] > 0) errval = val/sqrt( (double)(icategories[0]) );
testi << "pythia8_test1 1 " << val << " " << errval << " " << endl;

cout << endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the message logger.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, Giulio,
Do you mean that I should make another request? Please note that this
code is intended only for me,
and the output should be in a separate file.
Regards, Mikhail

On 9/11/13 5:50 PM, Giulio Eulisse wrote:

In GeneratorInterface/Pythia8Interface/test/ZJetsAnalyzer.cc:

+{

  • ofstream testi("testi.dat");
  • double val, errval;
  • Handle< GenRunInfoProduct > genRunInfoProduct;
  • r.getByLabel("generator", genRunInfoProduct );
  • val = (double)genRunInfoProduct->crossSection();
  • cout << endl;
  • cout << "cross section = " << val << endl;
  • cout << endl;
  • errval = 0.;
  • if(icategories[0] > 0) errval = val/sqrt( (double)(icategories[0]) );
  • testi << "pythia8_test1 1 " << val << " " << errval << " " << endl;
  • cout << endl;

Please use the message logger.


Reply to this email directly or view it on GitHub
https://github.com/cms-sw/cmssw/pull/775/files#r6293894.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, Giulio, Do you mean that I should make another request? Please note
that this code is intended only for me, and the output should be in a
separate file.

You can leave it as it is for now, but this should be cleaned up at some point
IMHO.

@Dr15Jones, do you remember if / how the message logger supports multiple
output streams?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does support multiple streams but I can never remeber the configuration syntax to do the work. A quick googling came up with

https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideMessageLogger#Configuring_destinations

@vciulli
Copy link
Contributor

vciulli commented Sep 13, 2013

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Sep 14, 2013
Generators Fixes -- Fix decay pi0 after Tauola++ migration.
@ktf ktf merged commit bd52595 into cms-sw:CMSSW_7_0_X Sep 14, 2013
bendavid pushed a commit to bendavid/cmssw that referenced this pull request Sep 28, 2014
Generators Fixes -- Fix decay pi0 after Tauola++ migration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants