bsunanda:IsoParticle74-1 #7806
bsunanda:IsoParticle74-1 #7806
Conversation
|
A new Pull Request was created by @cmsbuild for CMSSW_7_5_X. bsunanda:IsoParticle74-1 It involves the following packages: Calibration/IsolatedParticles @cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please review it and eventually sign? Thanks. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
| @@ -502,31 +705,37 @@ void IsoTrackCalibration::beginJob() { | |||
| tree->Branch("t_eHcal", &t_eHcal, "t_eHcal/D"); | |||
| tree->Branch("t_hmaxNearP", &t_hmaxNearP, "t_hmaxNearP/D"); | |||
| tree->Branch("t_selectTk", &t_selectTk, "t_selectTk/O"); | |||
| tree->Branch("t_qltyFlag", &t_qltyFlag, "t_qltyFlag/O"); | |||
| tree->Branch("t_qltyMissFlag",&t_qltyMissFlag,"t_qltyMissFlag/O"); | |||
| tree->Branch("t_qltyPVFlag", &t_qltyPVFlag, "t_qltyPVFlag/O)"); | |||
|
|
|||
| t_DetIds = new std::vector<unsigned int>(); | |||
There was a problem hiding this comment.
looks like a memory leak? perhaps t_DetIds does not need to be a pointer? (same with t_trgbits)
|
@bsunanda - maybe you did not get my comment above in this PR? |
|
What comments? On Mon, 9 Mar 2015, David Lange wrote:
|
|
just above on the web interface (sorry, I'm defeated in trying to give you a link..) |
|
Hi David I dont think there is an issue of leakage. We clear this vector every Sunanda On Mon, 9 Mar 2015, David Lange wrote:
|
|
but the vector itself is leaked... you need a delete t_detIds; somewhere (or maybe better, make t_detIds not a pointer.. |
|
+1 |
bsunanda:IsoParticle74-1
Tests for the latest improvement of IsoTrack trigger and analysis
Automatically ported from CMSSW_7_4_X #7504