csc geom kill const cast

[ptcox]

Replaced a long-standing const_cast embedded in CSCGeometry.cc 9 years ago. I think it was probably done because no const GeomDetType* was available then? But a year or two later the organization of the GeomDetType's seemed to settle down and it could have been fixed as I have done here. I've run the runthematrix Reco tests in case of some astonishing feedthrough effects but they all pass just fine :)

[cmsbuild]

A new Pull Request was created by @ptcox for CMSSW_7_5_X.

csc geom kill const cast

It involves the following packages:

Geometry/CSCGeometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Dr15Jones]

Thanks!

[Dr15Jones]

Please test

[cmsbuild]

The tests are being triggered in jenkins.

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7876/2795/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlange6]

+1