Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hf show lib cor01 #7895

Merged
merged 3 commits into from
Feb 25, 2015
Merged

Hf show lib cor01 #7895

merged 3 commits into from
Feb 25, 2015

Conversation

Vlandr57
Copy link
Contributor

Rename classes with capital letter for HF Shower LIbrary in FastSim.
Add material correction in FastSim when HF Shower Library is used.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Vlandr57 for CMSSW_7_4_X.

Hf show lib cor01

It involves the following packages:

FastSimulation/Calorimetry
FastSimulation/EventProducer
FastSimulation/ShowerDevelopment

@ssekmen, @nclopezo, @lveldere, @civanch, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lveldere
Copy link
Contributor

+1

@cmsbuild please test

@Vlandr57
Thanks a lot!
We'll need to revisit the way this is implemented,
once Knut is ready with his general framework for calorimeter corrections.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@lveldere
Copy link
Contributor

@davidlange6

could this be merged into 74X?
will it be forward ported to 75X automatically, or should it be done manually?

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants