Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from getByLabel to getByToken for SimHitTPAssociationProducer #7996

Merged
merged 1 commit into from
Mar 1, 2015
Merged

Migrate from getByLabel to getByToken for SimHitTPAssociationProducer #7996

merged 1 commit into from
Mar 1, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Feb 27, 2015

The consumes interface for SimHitTPAssociationProducer was pull requested and merged yesterday. Since it was decided that the migration to getByToken should be done at the same time, this PR is the corresponding migration from getByLabel to getByToken.

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Feb 27, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_5_X.

Migrate from getByLabel to getByToken for SimHitTPAssociationProducer

It involves the following packages:

SimGeneral/TrackingAnalysis

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@battibass, @makortel, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @cerati, @trocino, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@wmtan wmtan force-pushed the ConsumesSimHitTPAssociationProducer branch from 7b4dc1f to 43468ed Compare February 27, 2015 22:04
@cmsbuild
Copy link
Contributor

Pull request #7996 was updated. @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please check and sign again.

@wmtan
Copy link
Contributor Author

wmtan commented Feb 28, 2015

@cmsbuild please test

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2015

+1
Tested at: 43468ed
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7996/3001/summary.html

davidlange6 added a commit that referenced this pull request Mar 1, 2015
@davidlange6
Merge pull request #7996 from wmtan/ConsumesSimHitTPAssociationProducer
f910793 
Migrate from getByLabel to getByToken for SimHitTPAssociationProducer
@davidlange6 davidlange6 merged commit f910793 into cms-sw:CMSSW_7_5_X Mar 1, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7996/3001/summary.html

@wmtan wmtan deleted the ConsumesSimHitTPAssociationProducer branch March 5, 2015 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending orp-pending pending-signatures simulation-pending tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.
3 participants
@wmtan @cmsbuild @davidlange6