Remove static pointer holding Pandora

[lgray]

An attempt at fixing an issue where rechits provided to pandora would not point back to PFRecHits original provided in memory. Best guess is that putting the rather sneaky circumventions of const-correctness within pandora did not play nicely with being pointed to by a static pointer.

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_6_2_X_SLHC.

Remove static pointer holding Pandora

It involves the following packages:

RecoParticleFlow/PandoraTranslator

The following packages do not have a category, yet:

RecoParticleFlow/PandoraTranslator

@cmsbuild, @nclopezo can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Dr15Jones]

What is the plan for making this thread friendly?

[Dr15Jones]

Sorry, I missed that this was SLHC.

[lgray]

@Dr15Jones I need to speak with John Marshall and Mark Thompson about this. Their framework is inherently not threadsafe.

[cmsbuild]

+1
Tested at: c832d38
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8003/3008/summary.html

[mark-grimes]

merge