Remove dependency on XDAQ from HcalOnlineDb #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A compatibility library has been added called xdaq_compat. It includes a
typedef for replacing log4cplus, and copies the toString function from
toolbox.
Most of the changes introduced in this patch are revertible at compile
time by passing the definition "HAVE_XDAQ" to the compiler.
A summary of the changes follows:
* log4cplus/logger has been replaced with an ostream
* toolbox::toString has been copied into xdaq_compat.h
* xgi/Utils.h was unused and so removed
* Fix inheritance problem from std::exception
std::exception defines `virtual ~Exception() throw()`, whereas the
hcal::exception::Exception was trying to overwrite this with `virtual
~Exception {}`. This lead to a "looser throw specifier" error. As the
derived class has no reason to redefine this method, it had been
removed.
This is a forward port of cms-sw#737.
|
A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_0_X. Remove dependency on XDAQ from HcalOnlineDb It involves the following packages: CaloOnlineTools/HcalOnlineDb @ggovi, @apfeiffer1 can you please review it and eventually sign? Thanks. |
|
Notice this is a showstopper for pre4. |
|
Hi, I ran the usual tests on top of CMSSW_7_0_X_2013-09-12-0200, all tests passed: |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. |
ktf
added a commit
that referenced
this pull request
Sep 12, 2013
Remove dependency on XDAQ from HcalOnlineDb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A compatibility library has been added called xdaq_compat. It includes a
typedef for replacing log4cplus, and copies the toString function from
toolbox.
Most of the changes introduced in this patch are revertible at compile
time by passing the definition "HAVE_XDAQ" to the compiler.
A summary of the changes follows:
log4cplus/logger has been replaced with an ostream
toolbox::toString has been copied into xdaq_compat.h
xgi/Utils.h was unused and so removed
Fix inheritance problem from std::exception
std::exception defines
virtual ~Exception() throw(), whereas thehcal::exception::Exception was trying to overwrite this with
virtual ~Exception {}. This lead to a "looser throw specifier" error. As thederived class has no reason to redefine this method, it had been
removed.
This is a forward port of #737.