cout replaced by LogVerbatim #8041
Conversation
|
A new Pull Request was created by @ptcox for CMSSW_7_5_X. cout replaced by LogVerbatim It involves the following packages: DataFormats/CSCDigi @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks. |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
cmsbuild
added
comparison-pending
fully-signed
orp-pending
and removed
comparison-pending
fully-signed
orp-pending
simulation-approved
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
|
+1 |
Converted all occurrences of cout in DataFormats/CSCDigi/ to MessageLogger. There were 11 .cc files containing 'cout' in print() functions, They have all been converted to LogVerbatim. I've only tested some of them but that's fine because they're never used in production anyway - they're used for expert debugging only. The standard "runTheMatrix.py -s --useInput all" tests run fine, unsurprisingly, in 7_5_X. I was assured by Chris Jones that making this change should not affect the Digi structure, or break compatibility in any way :)