Small fix to PR #7823 (Adding the retina fitter)

[mark-grimes]

This fixes a potential memory leak in #7823 if the RetinaTrackFitter::fit function returns early. There's a comment on #7823 explaining where this can happen. I have no idea how likely the condition is to be met, but safer not to introduce any potential for a memory leak.

Changing the hits vector to an edm::OwnVector would have been a more "CMSSW friendly" solution, but that would have required changing the class interface since the vector is passed around.

@sviret, let me know if you're happy with this solution. You should be able to see just my changes at 7463d30.

(EDIT - that link for the commit with my changes isn't working for some reason. No idea why.)

[cmsbuild]

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Small fix to PR #7823 (Adding the retina fitter)

It involves the following packages:

L1Trigger/TrackFindingAM

@cmsbuild, @nclopezo, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mark-grimes]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 7463d30
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8046/3080/summary.html

[mulhearn]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @ktf, @fratnikov, @mark-grimes, @smuzaffar

[mark-grimes]

merge

@sviret, I assume no complaint means my change is okay.