Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the ecal summary report value #8145

Merged
merged 1 commit into from
Mar 11, 2015
Merged

fix the ecal summary report value #8145

merged 1 commit into from
Mar 11, 2015

Conversation

mengleisun
Copy link
Contributor

Fix the value of ECAL DQM summary report, so that it shows "NO DAQ" when ECAL is out.

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Mar 9, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2015

A new Pull Request was created by @mengleisun for CMSSW_7_4_X.

fix the ecal summary report value

It involves the following packages:

DQM/EcalMonitorClient

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Mar 10, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@deguio
Copy link
Contributor

deguio commented Mar 10, 2015

@mengleisun
could you please back port this to 73 as well?
thanks,
F.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8145/6529/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 11, 2015
@cmsbuild
Merge pull request #8145 from mengleisun/ECALDQM
577773f 
fix the ecal summary report value
@cmsbuild cmsbuild merged commit 577773f into cms-sw:CMSSW_7_4_X Mar 11, 2015
@mengleisun
Copy link
Contributor Author

@deguio
Hi Federico,
I have sent another PR for 7_3_X.

cheers,
Menglei

@mengleisun mengleisun deleted the ECALDQM branch August 4, 2017 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.
4 participants
@mengleisun @cmsbuild @deguio @davidlange6