Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing namespaces or includes #816

Merged
merged 1 commit into from
Sep 12, 2013

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Sep 12, 2013

This pull request is purely technical, and signatures should be bypassed.
When compiling CMSSW against ROOT 6, these packages or files did not compile because of either missing "std::" qualifiers or a missing iostream header. This pull request adds them.

The file in FastSimulation looks like it was totally modified, but that is just because it was formerly in DOS format. The only change was changing ifstream to std::ifstream in one place.

It would be very helpful to the ROOT6 effort if this request was merged in a timely manner.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_0_X.

add missing namespaces or includes

It involves the following packages:

L1TriggerConfig/RCTConfigProducers
DQM/HcalMonitorClient
DQM/SiStripCommissioningSources
CommonTools/TrackerMap
FastSimulation/CaloRecHitsProducer
Alignment/HIPAlignmentAlgorithm

@thspeer, @deguio, @demattia, @danduggan, @rovere, @rcastello, @giamman, @slava77, @mulhearn can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@ktf
Copy link
Contributor

ktf commented Sep 12, 2013

Timely. Not tested. Trusting Bill.

ktf added a commit that referenced this pull request Sep 12, 2013
add missing namespaces or includes
@ktf ktf merged commit 3e9eec0 into cms-sw:CMSSW_7_0_X Sep 12, 2013
@giamman
Copy link
Contributor

giamman commented Sep 13, 2013

+1

@wmtan wmtan deleted the AddMissingStdOrInclude branch September 14, 2013 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants