Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in separating H/E methods for barrel and endcap #8169

Merged

Conversation

hengne
Copy link
Contributor

@hengne hengne commented Mar 10, 2015

fix bug in separating H/E methods for barrel and endcap

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hengne (Hengne Li) for CMSSW_6_2_X_SLHC.

fix bug in separating H/E methods for barrel and endcap

It involves the following packages:

RecoEgamma/EgammaElectronProducers

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@mark-grimes
Copy link

merge

Not sure why the cmsbuild tests are taking so long. I tested privately with #8166 to check it fixes the problem, and all 20 standard tests pass.

cmsbuild added a commit that referenced this pull request Mar 10, 2015
fix bug in separating H/E methods for barrel and endcap
@cmsbuild cmsbuild merged commit cdaabbc into cms-sw:CMSSW_6_2_X_SLHC Mar 10, 2015
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants