Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini aod substructure pieces overhaul, rebase of #7659 : Port to 75x #8176

Conversation

rappoccio
Copy link
Contributor

Forward port of #8175

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rappoccio for CMSSW_7_5_X.

Mini aod substructure pieces overhaul, rebase of #7659 : Port to 75x

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ferencek
Copy link
Contributor

@rappoccio, it seems that this one can now be closed since the necessary code changes got propagated through #8357.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@rappoccio
Copy link
Contributor Author

@ferencek I don't know how everyone wants to handle this, the other PR is still not merged. I don't have a strong opinion on whichever gets closed.

@ferencek
Copy link
Contributor

@rappoccio, #8357 is already merged which is why I posted my previous message. But now I see that #8357 has some failed tests after being merged so I'm not sure how that will be handled. So for now maybe it is better to keep this one open. Not sure.

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 21, 2015
…entedChecking

Mini aod substructure pieces overhaul, rebase of #7659 : Port to 75x
@cmsbuild cmsbuild merged commit 4664d55 into cms-sw:CMSSW_7_5_X Mar 21, 2015
@rappoccio rappoccio deleted the MiniAODSubstructurePiecesAugmentedChecking branch April 22, 2015 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants