Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary and dangerous mutable qualifiers #8186

Merged
merged 1 commit into from
Mar 12, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Mar 10, 2015

This pull request removes the unnecessary and dangerous mutable qualifier from three InputTag data members of class L1GtUtils.
The qualifiers are unnecessary because these data members are not, in fact, modified, as everything builds fine when these qualifiers are removed.
These mutable qualifiers are dangerous for thread safety. They are also incompatible with the consumes interface, as the InputTags of consumed data members must be known at construction time.

@wmtan wmtan changed the title Remove unnecessary and dangerous mtable qualifiers Remove unnecessary and dangerous mutable qualifiers Mar 10, 2015
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Mar 10, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_5_X.

Remove unnecessary and dangerous mutable qualifiers

It involves the following packages:

L1Trigger/GlobalTriggerAnalyzer

@cmsbuild, @nclopezo, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Mar 12, 2015
Remove unnecessary and dangerous mutable qualifiers
@davidlange6 davidlange6 merged commit 3feb2f3 into cms-sw:CMSSW_7_5_X Mar 12, 2015
@wmtan wmtan deleted the RemoveMutableQualifier branch March 12, 2015 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants