Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to consumes -- CSCSkim #820

Merged
merged 2 commits into from
Sep 25, 2013
Merged

Conversation

ptcox
Copy link
Contributor

@ptcox ptcox commented Sep 13, 2013

Add consumes interface to DPGAnalysis/Skims/CSCSkim. This compiles fine and looks OK to me, but is untested since I have no convenient way to do it. I avoid the necessity of modifying 14 associated config files by hard-coding the InputTags for sim and real wire and strip digis required by the consumes interface. (The existing configs only contain InputTags for rechits, segments, trand-alone muons, global muons, tracks.)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ptcox for CMSSW_7_0_X.

Consumes to CSCSkim

It involves the following packages:

DPGAnalysis/Skims

@franzoni, @fabiocos, @vlimant can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@ktf
Copy link
Contributor

ktf commented Sep 13, 2013

@fabiocos who should sign off for skims nowadays?

@nclopezo
Copy link
Contributor

@fabiocos
Copy link
Contributor

As discussed at the ORP today this code is basically unattended as present.
If the technical checks are passed (as D. Mendes is reporting) please take it. Validations will have
to assess the physics correctness of it.

Fabio

On Sep 13, 2013, at 12:31 PM, Giulio Eulisse notifications@github.com wrote:

@fabiocos who should sign off for skims nowadays?


Reply to this email directly or view it on GitHub.

@ktf
Copy link
Contributor

ktf commented Sep 13, 2013

Moved to pre5 until we find a maintainer. @cerminar

ktf added a commit that referenced this pull request Sep 25, 2013
Migration to consumes -- CSCSkim
@ktf ktf merged commit 70c7f17 into cms-sw:CMSSW_7_0_X Sep 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants