Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing pixel saturation for heb #8220

Merged
merged 2 commits into from
Mar 12, 2015

Conversation

pfs
Copy link
Contributor

@pfs pfs commented Mar 12, 2015

Relaxing constraint on max. number of pixels in BH which implied a saturation after digitisation.
The previous constraint was bound to the CALICE test beam benchmark.

@vandreev11 As just agreed.
@lgray

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pfs (Pedro Silva) for CMSSW_6_2_X_SLHC.

removing pixel saturation for heb

It involves the following packages:

SimGeneral/MixingModule

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

merge

As with #8187 we'll get this in the 14:00 IB and then test with the updated pandora external. If there are problems we can fix or revert then.

cmsbuild added a commit that referenced this pull request Mar 12, 2015
@cmsbuild cmsbuild merged commit 8ebef2a into cms-sw:CMSSW_6_2_X_SLHC Mar 12, 2015
@pfs pfs deleted the hgc_removesaturation branch November 18, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants