Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize SiStripMonitorTrack to perform less string operations. #8352

Merged
merged 1 commit into from Mar 18, 2015

Conversation

dmitrijus
Copy link
Contributor

Forward port of #8266 to 7_5_X

https://hypernews.cern.ch/HyperNews/CMS/get/swDevelopment/3171.html
(cherry picked from commit 345c6c7)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_5_X.

Optimize SiStripMonitorTrack to perform less string operations.

It involves the following packages:

DQM/SiStripCommon
DQM/SiStripMonitorCluster
DQM/SiStripMonitorDigi
DQM/SiStripMonitorTrack
Validation/TrackerRecHits

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@venturia, @VinInn, @threus, @wmtford this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Mar 17, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8352/3566/summary.html
There are some workflows for which there are errors in the baseline:
401.0 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals

@davidlange6
Copy link
Contributor

@nclopezo - seems the tests on this PR finished, but the bot didn't notice as they are still pending

davidlange6 added a commit that referenced this pull request Mar 18, 2015
Optimize SiStripMonitorTrack to perform less string operations.
@davidlange6 davidlange6 merged commit e093d46 into cms-sw:CMSSW_7_5_X Mar 18, 2015
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@nclopezo
Copy link
Contributor

@davidlange6 It was because you merged it while the bot was stuck. So it didn't check this PR when it woke up again. Anyway, I forced it to check this one again.

@davidlange6
Copy link
Contributor

@nclopezo - ah - so the bot was stuck most of the night - I had not realized at the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants