-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize SiStripMonitorTrack to perform less string operations. #8352
Optimize SiStripMonitorTrack to perform less string operations. #8352
Conversation
A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_5_X. Optimize SiStripMonitorTrack to perform less string operations. It involves the following packages: DQM/SiStripCommon @cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
Comparison is ready |
@nclopezo - seems the tests on this PR finished, but the bot didn't notice as they are still pending |
Optimize SiStripMonitorTrack to perform less string operations.
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
@davidlange6 It was because you merged it while the bot was stuck. So it didn't check this PR when it woke up again. Anyway, I forced it to check this one again. |
@nclopezo - ah - so the bot was stuck most of the night - I had not realized at the time |
Forward port of #8266 to 7_5_X
https://hypernews.cern.ch/HyperNews/CMS/get/swDevelopment/3171.html
(cherry picked from commit 345c6c7)