-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce CCC by 6% #8397
reduce CCC by 6% #8397
Conversation
A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_4_X. reduce CCC by 6% It involves the following packages: RecoLocalTracker/SiStripClusterizer @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
Are we applying the cluster charge cut at the clusterizer level? I think we have already discussed about that but I am scared if this is the case because we loose handles to monitor the detector, especially at the beginning of run2. |
@venturia, |
@cmsbuild please test |
Vincenzo, is it 4% or 6%? |
... numerically, it's 6%; so, it's the commit message that's off. |
The tests are being triggered in jenkins. |
I'm going to run higher stat tests |
I've just read this thread (sorry) SiStripClusterChargeCutNone = cms.PSet( JIRA ticket: |
+1 for #8397 68c9286 changes are as expected: more tracks, more charge on track, more time spent to reconstruct; fake rates are essentially unchanged, the efficiency goes up a bit. Technical performance changes in 25202 (TTbar PU35 run2 setup):
Here are a few plots indicating the effect of the cut change in DQM (wflow 25202) |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
+1 |
see presentation at TRK-POG on Monday 23/3/2015