Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce CCC by 6% #8397

Merged
merged 1 commit into from
Mar 19, 2015
Merged

reduce CCC by 6% #8397

merged 1 commit into from
Mar 19, 2015

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Mar 19, 2015

see presentation at TRK-POG on Monday 23/3/2015

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_4_X.

reduce CCC by 6%

It involves the following packages:

RecoLocalTracker/SiStripClusterizer

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @nickmccoll, @jlagram, @gpetruc, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@venturia
Copy link
Contributor

Are we applying the cluster charge cut at the clusterizer level? I think we have already discussed about that but I am scared if this is the case because we loose handles to monitor the detector, especially at the beginning of run2.

@VinInn
Copy link
Contributor Author

VinInn commented Mar 19, 2015

@venturia,
no we do not by default

@slava77
Copy link
Contributor

slava77 commented Mar 19, 2015

@cmsbuild please test

@slava77
Copy link
Contributor

slava77 commented Mar 19, 2015

Vincenzo, is it 4% or 6%?
the commit message and the subject of the PR don't match

@slava77
Copy link
Contributor

slava77 commented Mar 19, 2015

... numerically, it's 6%; so, it's the commit message that's off.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Mar 19, 2015

I'm going to run higher stat tests

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mtosi
Copy link
Contributor

mtosi commented Mar 19, 2015

I've just read this thread (sorry)
yes, please, we (HLT) have to be in synch w/ offline values

SiStripClusterChargeCutNone = cms.PSet(
value = cms.double(-1.0)
)
SiStripClusterChargeCutLoose = cms.PSet(
value = cms.double(1620.0)
)
SiStripClusterChargeCutTight = cms.PSet(
value = cms.double(1945.0)
)

JIRA ticket:
https://its.cern.ch/jira/browse/CMSHLT-308

@slava77
Copy link
Contributor

slava77 commented Mar 19, 2015

+1

for #8397 68c9286
tested with higher stats in CMSSW_7_4_X_2015-03-18-2300 /test area sign531/

changes are as expected: more tracks, more charge on track, more time spent to reconstruct; fake rates are essentially unchanged, the efficiency goes up a bit.

Technical performance changes in 25202 (TTbar PU35 run2 setup):

  • CPU in RECO sequence goes up by about 2.0%; (parts of) pixelLess and tobTec steps; and convTrack tracking are up by ~10% among the most significant ones
  • sizes:
    • the number of track increases by about 1%,
    • allConversions are up by ~6% (somewhat similar increase is visible in other "jetty" workflows)
    • which, with increases downstream, increases the AOD size by 0.6% (RECO size is up by 0.4%)

Here are a few plots indicating the effect of the cut change in DQM (wflow 25202)

wf25202_tecm_charge_ontrack_percm
wf25202_gen_techits
wf25202_gen_tibhits

3TeV dijet
wf1313_gen_eff_vs_r

wf25202_tidm_charge_ontrack_percm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants