Rewrite tracking MC validation scripts #8408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fficiency to FakeDuplicate Aim is to take as much as possible from the DQM files, after which a custom calculation is needed only for fake+duplicate rate. Therefore rename Efficiency class (and adjust the implementation) to emphasize this functionality.
…, in SimpleValidation move algoDirMap from constructor to doPlots()
…esult by given amount Also remove a spurious printout.
Main idea is that the name-argument of Plot could produce a non-histogram (typically a number), and then this function can transform them to one or more histograms
- Use style for HIST also if the histogram is a TGraph and drawStyle contains L (i.e. line). - Pass drawStyle to Draw() - Do not pass "F" to TLegend.AddEntry()
Use case is that the histogramModifier decreases the number of histograms, so we need alternative mechanism to deliver the legend labels.
- Possibility to specify TFile-specific subdirectory - Possibility to give plot output format in Plotter.draw() - New plots: number of tracks vs. DeltaR, dz, dxy - New plots: TrackingParticle lip and tip - GTs for new releases - Possibility to override a GT per sample and per release
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
|
+1 |
cmsbuild
added a commit
that referenced
this pull request
Mar 20, 2015
Rewrite tracking MC validation scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a rewrite of the tracking validation scripts. Main new features are
I have been using the script for tracking validation since 72X, so this is mainly to get it integrated for easier use by others.
Should not have any effect on standard workflows.
@rovere @VinInn