Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MiniAOD met fixes #8416

Merged
merged 10 commits into from
Mar 21, 2015
Merged

MiniAOD met fixes #8416

merged 10 commits into from
Mar 21, 2015

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Mar 19, 2015

On top of #8391

  • fix some issues when reading pat::MET
  • allow writing alternate METs without uncertainties
  • make puppi met be a type1 met but save also the raw met (i.e. just like for the pf met)
  • fix also uncertainties for the raw met

@mmarionncern @arizzi @mariadalfonso @jshlee

matthieu and others added 10 commits March 18, 2015 21:56
fix single particles variations for type2 MET
5712bcb
clean debug lines
6657223
@gpetruc
Fix class name in ioread for PackedMETUncertainty (otherwise it's not…
56bdee8 
… unpacked)
@gpetruc
MET::uncorrectedPhi should use shiftedPhi, not shiftedPt
b88a9e4
@gpetruc
Build also dictionary for pat::MET::Vector2, so that shiftedP2 can be…
5c73d4f 
… used in python and CINT. No need of persistency.
@gpetruc
Allow to store just the central value and not also all the shifts, in…
981ca31 
… case we don't have them
@gpetruc
In PAT MET Slimmer, allow getting only the central value (if there's …
ba02012 
…no %s is the input tag)
@gpetruc
Use a cone of 0.4 when computing MET uncertainties for ak4
c6f80cb
@gpetruc
Always use CorrectedPATMETProducer to propagate shifts (fixes also un…
bf0a409 
…certainties on Raw met)
@gpetruc
Make PAT Met a Type1 MET, and don't fill uncertainties since we don't…
4376813 
… have them
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Mar 19, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_7_4_X.

MiniAOD met fixes

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 4376813
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8416/3653/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8416/3653/summary.html

davidlange6 added a commit that referenced this pull request Mar 21, 2015
@davidlange6
Merge pull request #8416 from gpetruc/miniAOD_met_fixes
11a40a3 
MiniAOD met fixes
@davidlange6 davidlange6 merged commit 11a40a3 into cms-sw:CMSSW_7_4_X Mar 21, 2015
@mmarionncern mmarionncern mentioned this pull request Apr 7, 2015
Closed
@gpetruc gpetruc deleted the miniAOD_met_fixes branch September 30, 2015 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-available orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.
3 participants
@gpetruc @cmsbuild @davidlange6