Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in trigger path names for HLTriggerOffline/SUSYBSM #8433

Merged
merged 4 commits into from
Mar 31, 2015

Conversation

kmandal
Copy link
Contributor

@kmandal kmandal commented Mar 20, 2015

Some HLT path names have been changed to make SUSYBSM DQM package consistent with GRun menu.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kmandal (Koushik Mandal) for CMSSW_7_5_X.

From cmssw 7 5 x 2015 03 19 2300

It involves the following packages:

HLTriggerOffline/SUSYBSM

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ghost
Copy link

ghost commented Mar 23, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: bba2cb4
The relvals timed out after 1 hour.

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8433/3715/summary.html

@davidlange6
Copy link
Contributor

click the edit button next to the title on your pull request.

On Mar 30, 2015, at 6:50 PM, Koushik Mandal notifications@github.com wrote:

Hi,

Sorry for my ignorance. Could you please suggest me how to change the
title of a PR?

Thanks,
Koushik

On Mon, Mar 30, 2015 at 9:25 PM, deguio notifications@github.com wrote:

+1
@kmandal https://github.com/kmandal please change the title of this PR.
it won't be merged otherwise.
(approving though)


Reply to this email directly or view it on GitHub
#8433 (comment).

NISER, SPS

" DON'T FORGET YOUR ROOT...."

Reply to this email directly or view it on GitHub.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@kmandal kmandal changed the title From cmssw 7 5 x 2015 03 19 2300 Changes in trigger path names for HLTriggerOffline/SUSYBSM #8433 Mar 31, 2015
@kmandal kmandal changed the title Changes in trigger path names for HLTriggerOffline/SUSYBSM #8433 Changes in trigger path names for HLTriggerOffline/SUSYBSM Mar 31, 2015
@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants