Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed default HF file name #8492

Merged
merged 1 commit into from
Mar 24, 2015

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Mar 24, 2015

Fixed default name of HF shower library

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_5_3_X.

fixed default HF file name

It involves the following packages:

SimG4CMS/Calo
SimG4Core/Application

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor Author

civanch commented Mar 24, 2015

please test

@civanch
Copy link
Contributor Author

civanch commented Mar 24, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar, @ktf

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar, @ktf

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar, @ktf

@davidlange6
Copy link
Contributor

+1

@franzoni
Copy link

@bendavid @srimanob

hello @civanch,
what is the effect of these changes on the standard SIM sequence of 5_3 x ?

We need to deploy this release in production to acquire some GEN new features.
Can we be sure we're not affecting the physics performance of SIM?

Cheers,
Giovanni

@davidlange6
Copy link
Contributor

Hi @franzoni

There is no effect. the HF shower library is not used in 53x.

On Mar 26, 2015, at 7:22 PM, Giovanni Franzoni notifications@github.com wrote:

@bendavid @srimanob

hello @civanch,
what is the effect of these changes on the standard SIM sequence of 5_3 x ?

We need to deploy this release in production to acquire some GEN new features.
Can we be sure we're not affecting the physics performance of SIM?

Cheers,
Giovanni


Reply to this email directly or view it on GitHub.

@franzoni
Copy link

Thanks, David @davidlange6

@civanch
Copy link
Contributor Author

civanch commented Mar 27, 2015

Hi Giovanni,

New HF SL included in 5_3_X is not used by default, it may be enabled via
customisation. So, by default nothing should be changed in SIM.

Cheers,
Vladimir

On Thu, 26 Mar 2015, Giovanni Franzoni wrote:

@bendavid @srimanob

hello @civanch,
what is the effect of these changes on the standard SIM sequence of 5_3 x ?

We need to deploy this release in production to acquire some GEN new features.
Can we be sure we're not affecting the physics performance of SIM?

Cheers,
Giovanni

?
Reply to this email directly or view it on GitHub.[AEub7tHReAc1Up4B87YKg_k4Im5qWPbDks5n5EX5gaJpZM4Dzur4.gif]

@franzoni
Copy link

Thanks, Vladimir. g.

On 27 March 2015 at 18:18, Vladimir Ivantchenko notifications@github.com
wrote:

Hi Giovanni,

New HF SL included in 5_3_X is not used by default, it may be enabled via
customisation. So, by default nothing should be changed in SIM.

Cheers,
Vladimir

On Thu, 26 Mar 2015, Giovanni Franzoni wrote:

@bendavid @srimanob

hello @civanch,
what is the effect of these changes on the standard SIM sequence of 5_3
x ?

We need to deploy this release in production to acquire some GEN new
features.
Can we be sure we're not affecting the physics performance of SIM?

Cheers,
Giovanni

?
Reply to this email directly or view it on
GitHub.[AEub7tHReAc1Up4B87YKg_k4Im5qWPbDks5n5EX5gaJpZM4Dzur4.gif]


Reply to this email directly or view it on GitHub
#8492 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants