Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSim bugfix for gtDigis (7_4_X) #8585

Merged
merged 4 commits into from
Apr 2, 2015
Merged

FastSim bugfix for gtDigis (7_4_X) #8585

merged 4 commits into from
Apr 2, 2015

Conversation

lveldere
Copy link
Contributor

make the emulated gtDigis available under the label 'gtDigis' with an EDAlias to 'simGtDigis', required by HLT

@lveldere lveldere changed the title FastSim bugfix for gtDigis FastSim bugfix for gtDigis (7_4_X) Mar 30, 2015
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Mar 30, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lveldere for CMSSW_7_4_X.

FastSim bugfix for gtDigis (7_4_X)

It involves the following packages:

FastSimulation/HighLevelTrigger

@ssekmen, @nclopezo, @lveldere, @civanch, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lveldere
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@danduggan
Copy link
Contributor

@lveldere, please be sure to submit a corresponding PR to the 75X release cycle

@lveldere
Copy link
Contributor Author

lveldere commented Apr 2, 2015

it's taken care of

#8489 takes care of the hlt btag
validator
#8455 includes the fix to the gtDigis
label

On Thu, Apr 2, 2015 at 10:36 AM, danduggan notifications@github.com wrote:

@lveldere https://github.com/lveldere, please be sure to submit a
corresponding PR to the 75X release cycle


Reply to this email directly or view it on GitHub
#8585 (comment).

@danduggan
Copy link
Contributor

ok perfect, thanks for the confirmation.

On Thu, Apr 2, 2015 at 10:49 AM, lveldere notifications@github.com wrote:

it's taken care of

#8489 takes care of the hlt btag
validator
#8455 includes the fix to the gtDigis
label

On Thu, Apr 2, 2015 at 10:36 AM, danduggan notifications@github.com
wrote:

@lveldere https://github.com/lveldere, please be sure to submit a
corresponding PR to the 75X release cycle


Reply to this email directly or view it on GitHub
#8585 (comment).


Reply to this email directly or view it on GitHub
#8585 (comment).

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants