Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix runTheMatrix Workflows (fast timing + recycling) #8613

Merged
merged 5 commits into from Apr 2, 2015
Merged

Fix runTheMatrix Workflows (fast timing + recycling) #8613

merged 5 commits into from Apr 2, 2015

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Mar 31, 2015

  • Fix event content for fasttiming
  • Fix a typo when using the gensim recycling functionnality

@cmsbuild cmsbuild added this to the Next CMSSW_6_2_X_SLHC milestone Mar 31, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @boudoul (boudoul) for CMSSW_6_2_X_SLHC.

Fix runTheMatrix Workflows (fast timing + recycling)

It involves the following packages:

Configuration/PyReleaseValidation
SLHCUpgradeSimulations/Configuration

@civanch, @nclopezo, @boudoul, @franzoni, @mdhildreth, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2015

+1
Tested at: 6dafc07
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8613/4037/summary.html

#Cake, and grief counseling, will be available at the conclusion of the test...

fratnikov
fratnikov reviewed Apr 1, 2015
View reviewed changes
SLHCUpgradeSimulations/Configuration/python/combinedCustoms.py
process.RECOSIMEventContent.outputCommands.append('keep *_cfWriter_g4SimHits_*')
if hasattr(process,'FEVTDEBUTeventContent'):
process.FEVTDEBUGoutput.outputCommands.append('keep *_cfWriter_g4SimHits_*')
process.RECOSIMEventContentEventContent.outputCommands.append('keep *_cfWriter_g4SimHits_*')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is expected to be "process.RECOSIMEventContentEventContent" indeed?

@boudoul
Copy link
Contributor Author

boudoul commented Apr 2, 2015

@fratnikov , I removed the stupid process.RECOSIMEventContentEventContent I mistakely introduced.
Thanks for noticing.

@fratnikov
Copy link

merge

cmsbuild added a commit that referenced this pull request Apr 2, 2015
@cmsbuild
Merge pull request #8613 from boudoul/FixRunTheMatrix
c498421 
Fix runTheMatrix Workflows (fast timing + recycling)
@cmsbuild cmsbuild merged commit c498421 into cms-sw:CMSSW_6_2_X_SLHC Apr 2, 2015
@fratnikov fratnikov mentioned this pull request Apr 2, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending orp-pending pdmv-pending pending-signatures simulation-pending tests-approved
Projects
None yet
Milestone
Next CMSSW_6_2_X_SLHC
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boudoul @cmsbuild @fratnikov