Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter for parton shower b #8644

Merged
merged 2 commits into from Apr 8, 2015

Conversation

bortigno
Copy link
Contributor

@bortigno bortigno commented Apr 2, 2015

Hello,

This is a pull request for a flavour/status filter I used to created events enriched in bs from parton shower using the lhe multiple hadronizer. The pull request includes a cfg where I tested the filter using a DYJets production.

Thank you,
Pier

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2015

A new Pull Request was created by @bortigno (Pierluigi Bortignon) for CMSSW_7_5_X.

Filter for parton shower b

It involves the following packages:

GeneratorInterface/Core

@vciulli, @covarell, @thuer, @cmsbuild, @nclopezo, @bendavid can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@bendavid
Copy link
Contributor

bendavid commented Apr 2, 2015

I think you miss the change in HepMCFilterDriver to add the string to the list of known filter names.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2015

Pull request #8644 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @nclopezo, @bendavid can you please check and sign again.

@bortigno
Copy link
Contributor Author

bortigno commented Apr 2, 2015

Hi Josh, you are right, sorry I forgot to commit it. I just updated it! Thanks

@bendavid
Copy link
Contributor

bendavid commented Apr 2, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2015

-1
Tested at: 5a67568
When I ran the RelVals I found an error in the following worklfows:
9.0 step4

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step4_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8644/7008/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

davidlange6 added a commit that referenced this pull request Apr 8, 2015
@davidlange6 davidlange6 merged commit 07bd3a5 into cms-sw:CMSSW_7_5_X Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants