-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macros need to compile in ROOT6 (Vis) (74X) #8737
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_4_X. Macros need to compile in ROOT6 (Vis) (74X) It involves the following packages: Fireworks/Geometry @cmsbuild, @alja, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
These changes appear OK for ROOT5, but I can't be 100% sure. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
+1 |
Macros need to compile in ROOT6 (Vis) (74X)
In ROOT6 macros are processed by cling, rather than CINT. Over 500 CMSSW macros do not compile in ROOT6. Since that is too many macros to be fixed centrally, it was decided by David Lange to centrally fix only those 45 macros with compilation errors that have been modified since the switch over to git, since those are the ones most likely to be used. Only one of these 45 macros is in the Visualization L2 category. This pull request fixes it, plus other macros in the same package with the same problem.