Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macros need to compile in ROOT6 (ALCA) (7_4_X) #8744

Merged
merged 1 commit into from May 11, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Apr 14, 2015

In ROOT6 macros are processed by cling, rather than CINT. Over 500 CMSSW macros do not compile in ROOT6. Since that is too many macros to be fixed centrally, it was decided by David Lange to centrally fix only those 45 macros with compilation errors that have been modified since the switch over to git, since those are the ones most likely to be used. Only four of these 45 macros are in the ALCA L2 category. This pull request fixes them.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_4_X.

Macros need to compile in ROOT6 (ALCA) (7_4_X)

It involves the following packages:

Alignment/OfflineValidation
CalibTracker/SiStripChannelGain
Calibration/IsolatedParticles

@cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @frmeier, @gbenelli, @jlagram, @tlampen, @mschrode, @mmusich, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@wmtan
Copy link
Contributor Author

wmtan commented Apr 15, 2015

It appears that these changes are OK for ROOT5, but I can't be 100% sure.

@mmusich
Copy link
Contributor

mmusich commented Apr 15, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Apr 15, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants