Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC efficiency distribution bugfix #8881

Merged
merged 1 commit into from
Apr 30, 2015

Conversation

jhgoh
Copy link
Contributor

@jhgoh jhgoh commented Apr 27, 2015

RPC efficiency ME naming scheme was changed in the 7XY development but this client module (RPCEfficiencyShiftHisto) was not updated.
Wheel +1 and +2 are skipped in the RPC efficiency distribution plot; thus the nEntries of "RPC/RPCEfficiency/EffBarrelRoll" plot was just ~600 which had to be ~1000 (=number of rolls in barrel).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jhgoh (Junghwan John Goh) for CMSSW_7_5_X.

RPC efficiency distribution bugfix

It involves the following packages:

DQM/RPCMonitorClient

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Apr 29, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Apr 30, 2015
@cmsbuild cmsbuild merged commit f14de5b into cms-sw:CMSSW_7_5_X Apr 30, 2015
cmsbuild added a commit that referenced this pull request May 2, 2015
RPC efficiency distribution bugfix (backport #8881)
cmsbuild added a commit that referenced this pull request May 5, 2015
RPC efficiency distribution bugfix (backport #8881)
@jhgoh jhgoh deleted the RPCRollEfficiencyBugfix branch May 6, 2015 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants