Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing adler32 with CRC32-C in FRD (raw data format) v5 - 74X #8908

Merged
merged 5 commits into from
May 11, 2015
Merged

Replacing adler32 with CRC32-C in FRD (raw data format) v5 - 74X #8908

merged 5 commits into from
May 11, 2015

Conversation

smorovic
Copy link
Contributor

  • correct unlock in input source at the end of the run
  • "Failsafe" is set as JSON stream destination field in case of unsucessful determination with HLT menu and selected transfermode
  • renamed reserved TCDS FED header variable to triggerTypeFlags
  • support for Intel acceleration of CRC-32C with new FRD v5 (replaces adler32)

@smorovic
triggerTypeFlags bitmask (was reserved4) in TCDS header interface
300aa87
@smorovic
lock --> unlock (not critical as process exits and releases the lock …
2b8cc38 
…shortly after)
@smorovic
*added SSE 4.2 accelerated CRC32-C
b4bb683 
 Original implementation by Mark Adler patched to compile as C++ and
 introduced ifdefs to compile SSE 4.2 asm version only for X86_64,
 otherwise using fallback to software crc32c implementation
*changes to support checking crc32c checksum in both raw input sources (V5 of the FRD format),
 included also support for V4 header
*ability to generate new FRD v5 format and checksum with fakeBU script
@smorovic
use "Failsafe" as reserved destination name when sdestination can't be
4215d7c 
calculated instead of empty string.
@smorovic
Copy link
Contributor Author

This is 74X pull request of commits in (75X) #8907

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Apr 28, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_4_X.

Replacing adler32 with CRC32-C in FRD (raw data format) v5 - 74X

It involves the following packages:

EventFilter/FEDInterface
EventFilter/Utilities
IOPool/Streamer

@mommsen, @cmsbuild, @Dr15Jones, @emeschi, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mommsen
Copy link
Contributor

mommsen commented Apr 29, 2015

+1

@cmsbuild
Copy link
Contributor

+1
Tested at: 4215d7c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8908/4459/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8908/4512/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request May 11, 2015
@cmsbuild
Merge pull request #8908 from smorovic/FRD-74X
ccd3784 
Replacing adler32 with CRC32-C in FRD (raw data format) v5 - 74X
@cmsbuild cmsbuild merged commit ccd3784 into cms-sw:CMSSW_7_4_X May 11, 2015
@smorovic smorovic deleted the FRD-74X branch May 19, 2015 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available core-approved daq-approved fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.
5 participants
@smorovic @cmsbuild @mommsen @Dr15Jones @davidlange6