Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of assorted fixes: process-prune-method and TriggerSummaryProducerAOD #8929

Merged
merged 1 commit into from
May 12, 2015

Conversation

Martin-Grunewald
Copy link
Contributor

Backport of Chris's #8828,
additional improvements in Config.py,
and improved error handling in TriggerSummaryProducerAOD

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_4_X.

Backport of assorted fixes: process-prune-method and TriggerSummaryProducerAOD

It involves the following packages:

FWCore/ParameterSet
HLTrigger/HLTcore

@perrotta, @cmsbuild, @Dr15Jones, @Martin-Grunewald, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1

Tested at: 4610f4f
I found errors in the following unit tests:

---> test testTechnologyPlugin had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8929/46/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

test failures seem unrelated - likely from massive checkdeps that this PR has.. merging and will hope no knock on problems

davidlange6 added a commit that referenced this pull request May 12, 2015
Backport of assorted fixes: process-prune-method and TriggerSummaryProducerAOD
@davidlange6 davidlange6 merged commit a16ca7a into cms-sw:CMSSW_7_4_X May 12, 2015
@cmsbuild
Copy link
Contributor

@Martin-Grunewald Martin-Grunewald deleted the AssortedFixes branch May 22, 2015 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants