Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for ouput ASCII file when writeTxt_ is set false #8987

Merged
merged 1 commit into from
May 11, 2015

Conversation

sushilchauhan
Copy link
Contributor

minor bug fix for output .txt files for the case when writeTxt_ is set to false otherwise it changes the name of the dip output file.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2015

A new Pull Request was created by @sushilchauhan for CMSSW_7_4_X.

bug fix for ouput ASCII file when writeTxt_ is set false

It involves the following packages:

RecoVertex/BeamSpotProducer

@nclopezo, @cvuosalo, @cerminar, @cmsbuild, @diguida, @slava77, @mmusich can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented May 7, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2015

The tests are being triggered in jenkins.

@deguio
Copy link
Contributor

deguio commented May 7, 2015

this is a minor fix needed for the online only.
F.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2015

-1
Tested at: c22b1ad
you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8987/5230/summary.html

@slava77
Copy link
Contributor

slava77 commented May 11, 2015

+1

for #8987 c22b1ad
the change is simple.
Considering that integration in 74X may be slow, I suggest you submit a PR in 75X as well, so that the forward port is not forgotten

@mmusich
Copy link
Contributor

mmusich commented May 11, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants