Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-threading support #9071

Merged
merged 5 commits into from
May 18, 2015
Merged

Conversation

kkrajczar
Copy link
Contributor

The purpose of this PR is to migrate four CMSSW "legacy" modules used by the Heavy Ions HLT to multi-threading compliant forms. For reference, the Hypernews thread on HLT Development about this change is https://hypernews.cern.ch/HyperNews/CMS/get/hlt/3872.html.

A backport to 74X will follow shortly. Thanks to @cfmcinn for testing the PR'd changes.

@Martin-Grunewald, @perrotta, @fwyzard, @cfmcinn, @yetkinyilmaz, @richard-cms might want to follow this PR.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kkrajczar (Krisztian Krajczar) for CMSSW_7_5_X.

Multi-threading support

It involves the following packages:

RecoEcal/EgammaClusterProducers
RecoHI/HiEgammaAlgos

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jazzitup, @argiro, @appeltel, @richard-cms, @yenjie, @kurtejung, @lgray, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fwyzard
Copy link
Contributor

fwyzard commented May 13, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #9071 879f2f5

Migration of HI HLT code to support multi-threading. It should not change monitored physics quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-05-12-2300 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants