-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boosted double SV tagger (74X) #9150
Boosted double SV tagger (74X) #9150
Conversation
A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_4_X. Boosted double SV tagger (74X) It involves the following packages: PhysicsTools/PatAlgos @nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please review it and eventually sign? Thanks. |
The tests are being triggered in jenkins. |
@monttj please check this PR and comment if there are remaining issues with an AT signature, or sign otherwise. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Can we push this one into the next 74X release? |
@ferencek - has been on my list - but is there an easy way to confirm that this does not change miniAOD? |
@davidlange6
|
Good - this is a subset of the requirements for not changing mini-aod:)
|
@davidlange6, the intention was to leave MiniAOD intact which Slava's logs confirm. |
@ferencek - ok thanks - i fear little that gets tested confirms this so I was looking for confirmation on the intent of the PR |
…CMSSW_7_4_1 Boosted double SV tagger (74X)
Backport of #9120
@cvernier