-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove class EDInputSource #9207
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_5_X. Remove class EDInputSource It involves the following packages: FWCore/Sources @cmsbuild, @Dr15Jones, @nclopezo can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
+1 |
This PR removes the superfluous class EDInputSource, moving its functionality into PoolSource, where it should have been in the first place. This PR reduces the depth of the PoolSource inheritance tree by 1,
reduces the number of lines of code by 68, reduces the number of files by 2, and results in simpler, more maintainable code. Altogether, a win-win.