Trim FastjetJetProducer memory (forward port #9203 to 74X) #9210
Conversation
|
A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_4_X. Trim FastjetJetProducer memory (forward port #9203 to 74X) It involves the following packages: RecoJets/JetProducers @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
On 5/23/15 1:58 PM, Carl Vuosalo wrote:
30-50 MB reduction is a lot, actually |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
Trim FastjetJetProducer memory (forward port #9203 to 74X)
This forward ports some memory improvements in FastjetJetProducer from 6_2_X_SLHC; there are some plots on #9203 with the memory saving. The 75X port is #9206, I was also advised to port to 74X.
This bit below is just the description copied from the 75X PR:
This forward ports some memory improvements found in 6_2_X_SLHC. At 200 pileup it saved ~70Mb memory, there are plots on #9203. Presumably at lower pileup the savings aren't as good.
Note that this is from empirically checking where the memory was being used - there could be other subclasses of
VirtualJetProducerthat would benefit from a similar fix. I didn't want to touch thefjClusterSeq_object in the base class because I didn't know how the other subclasses use it - forFastjetJetProducerI can see that it's recreated anew with every event.At 200 pileup 1/7th of the memory saving was from swapping out the work vectors, and 6/7th was from freeing the
fjClusterSeq_object.