Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reshape RunI-like tracking customization snippet. #9296

Merged
merged 2 commits into from May 28, 2015

Conversation

rovere
Copy link
Contributor

@rovere rovere commented May 27, 2015

Back-port of #8691 into 74X. Could be extremely useful also for the 0T scenario.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_7_4_X.

Reshape RunI-like tracking customization snippet.

It involves the following packages:

RecoTracker/Configuration
RecoTracker/IterativeTracking

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @VinInn, @appeltel, @mschrode, @gpetruc, @cerati, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented May 27, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented May 27, 2015

Hi Marco, just making a blind comparison of the number of lines, this PR doesn't match #8691
what are the changes?

@rovere
Copy link
Contributor Author

rovere commented May 27, 2015

@slava77 you are right, I might have missed 1 commit from #8691
I'll update this PR accordingly.
Thanks for noticing.

@slava77
Copy link
Contributor

slava77 commented May 27, 2015

ah, ok, good that I checked.
At brief inspection, it looks like the changes in tracking parameters in the _iteration_cff are missing

@rovere
Copy link
Contributor Author

rovere commented May 27, 2015

Here they are.

@slava77
Copy link
Contributor

slava77 commented May 28, 2015

summary for #9296 86fe202

  • tested locally in CMSSW_7_4_3 /test area sign743b/
  • the main test is based on run 200781 lumi=80 (~PU=30 with 0 T from 2012C) /store/data/Run2012C/MinimumBias/RAW/v1/000/200/781/7ED5DB39-DDE4-E111-9386-003048F118D2.root , using 1000.0 configuration otherwise. 100 events in the test.
  • technical performance seems comparable: processing time up from 10.6 to 13.7 s/evt (peak moves from 29.4 to 35.8 s/evt), both excluding the first event dominated by conditions fetch.

Some object comparisons notes

  • most tracks don't have MVA value assigned
    all_sign743b-200781vsorig-200781_runminbias2011awf1000p0c_floatedmvaluemap_generaltracks_mvavals_reco_obj_values_
  • there are 50% more tracks (from the following distributions they appear to be "better" tracks)
    all_sign743b-200781vsorig-200781_runminbias2011awf1000p0c_recotracks_generaltracks__reco_obj_pt

all_sign743b-200781vsorig-200781_runminbias2011awf1000p0c_minrecotracks_generaltracks__reco_obj_normalizedchi2 29
all_sign743b-200781vsorig-200781_runminbias2011awf1000p0c_recotracks_generaltracks__reco_obj_algo
all_sign743b-200781vsorig-200781_runminbias2011awf1000p0c_recotracks_generaltracks__reco_obj_eta
all_sign743b-200781vsorig-200781_runminbias2011awf1000p0c_recotracks_generaltracks__reco_obj_found

  • more electron gsf tracks as well
    all_sign743b-200781vsorig-200781_runminbias2011awf1000p0c_log10recogsftracks_electrongsftracks__reco_obj_pt
  • but fewer PF egamma objects (more tracks probably kill some of them in the preselection)
    all_sign743b-200781vsorig-200781_runminbias2011awf1000p0c_log10recopfcandidates_particleflowegamma__reco_obj_pt
  • calo jets change a bit (likely due to the track->hbhe cleaning step)
    all_sign743b-200781vsorig-200781_runminbias2011awf1000p0c_log10recocalojets_ak4calojets__reco_obj_et

PF reco is not quite trivial to understand (do we even know that it works OK?)

  • about 30% less charged hadrons (opposite to 50% more tracks .. looks like PF RECO doesn't like these tracks.)
    all_sign743b-200781vsorig-200781_runminbias2011awf1000p0c_log10recopfcandidates_particleflow__reco_obj_pt10
  • similar decrease in electrons (this should follow what happens in the egamma objects; since the sample is mostly fakes, the meaning of decrease is unclear)
    all_sign743b-200781vsorig-200781_runminbias2011awf1000p0c_log10recopfcandidates_particleflow__reco_obj_pt20
  • muons are ~unchanged
  • photons are ~unchanged
    all_sign743b-200781vsorig-200781_runminbias2011awf1000p0c_log10recopfcandidates_particleflow__reco_obj_pt40
  • ~15% more neutral hadrons
    all_sign743b-200781vsorig-200781_runminbias2011awf1000p0c_log10recopfcandidates_particleflow__reco_obj_pt50

Overall, there are indications that tracking is indeed better, but higher level reco downstream (PF, specifically) maybe just not well adjusted to the 0T input track properties.
MC with truth matching would help to understand what's happening.

@slava77
Copy link
Contributor

slava77 commented May 28, 2015

@bachtis Michalis, do you have any high expectations for PF reco with 0 T?
@lgray what about egamma?

@bachtis
Copy link
Contributor

bachtis commented May 28, 2015

Hi Slava ,
I have discussed with PC . There are many ideas that are configurable and could be done at PF @0t
Examples:
[Run PF without tracks ~ 20% improvement for jet resolution wrt CaloJets]
Link tracks and Calo deposits and create PF candidates with Calo energy and track direction [and try to associate to PV]

Now the request from PC was to not invest in that direction for the high level reconstruction for now since we are looking at a middle term solution.
just for my education: @rovere @VinInn what is the pt of the tracks at 0 T and the error that you give?

@VinInn
Copy link
Contributor

VinInn commented May 28, 2015

Seeds starts with 5GeV and some sort of large error.
than KalmanFilter is free to adjust most probably taking into account multiple-scattering...

@bachtis
Copy link
Contributor

bachtis commented May 28, 2015

OK then PF will give random results since it assumes ~5 GeV track energy. Unless the error is very very large so that it will prefer the calo measurement. Ideal configuration for PF to run out of the box would be : track pt = 0.0 +- 100 TeV

@slava77
Copy link
Contributor

slava77 commented May 28, 2015

+1

for #9296 86fe202

  • the new configuration can be enabled with --customise RecoTracker/Configuration/customiseForRunI.customiseForRunI
  • some performance notes were posted earlier in the thread

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants