Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PileupJetIdAlgo from DQM/PhysicsHWW. #9350

Merged
merged 3 commits into from Jul 8, 2015

Conversation

dmitrijus
Copy link
Contributor

... and use the proper one from RecoJets/JetProducers.

... and use the proper one from RecoJets/JetProducers.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_4_X.

Remove PileupJetIdAlgo from DQM/PhysicsHWW.

It involves the following packages:

DQM/PhysicsHWW

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@rappoccio this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jun 5, 2015

+1

for #9350 6da5b30

  • reco is minimally affected (removal of actually unimplemented but declared function in RecoJets/JetProducers/interface/PileupJetIdAlgo.h
  • compilation went OK and jenkins run time tests completed as well

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@deguio
Copy link
Contributor

deguio commented Jun 26, 2015

this one should be merged before #9919
thanks,
F.

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants