DataFormats/TauReco: clean dictionary of duplicate selection rules

[davidlt]

Thanks to Danilo ROOT 6.04.00 will have user-friendly duplicate
selection rule check.

Warning: Selection file classes_def_3.xml, lines 112 and 103. Attempt to
select with a named selection rule an already selected class. The name
used in the selection is
"reco::PFTauTransverseImpactParameterCollection" while the class is
"vector<reco::PFTauTransverseImpactParameter>".

Warning: Selection file classes_def_3.xml, lines 122 and 105. Attempt to
select with a named selection rule an already selected class. The name
used in the selection is "reco::PFTauTransverseImpactParameterRef" while
the class is
"edm::Ref<vector<reco::PFTauTransverseImpactParameter>,
reco::PFTauTransverseImpactParameter,
edm::refhelper::FindUsingAdvance<vector<reco::PFTauTransverseImpactParameter>,
reco::PFTauTransverseImpactParameter> >".

Warning: Selection file classes_def_3.xml, lines 192 and 181. Attempt to
select with a named selection rule an already selected class. The name
used in the selection is "reco::PFTau3ProngSummaryCollection" while the
class is "vector<reco::PFTau3ProngSummary>".

Warning: Selection file classes_def_3.xml, lines 204 and 183. Attempt to
select with a named selection rule an already selected class. The name
used in the selection is "reco::PFTau3ProngSummaryRef" while the class
is "edm::Ref<vector<reco::PFTau3ProngSummary>,reco::PFTau3ProngSummary,
edm::refhelper::FindUsingAdvance<vector<reco::PFTau3ProngSummary>,
reco::PFTau3ProngSummary> >".

Tested by comparing seal_cap.cc, which does not change after this
patchset.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

[cmsbuild]

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

DataFormats/TauReco: clean dictionary of duplicate selection rules

It involves the following packages:

DataFormats/TauReco

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@jpavel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
Tested at: 5b86426
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9362/5186/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9362/5186/summary.html

[slava77]

@smuzaffar please check the cms-bot status in this case
the comparisons are supposedly ready
#9362 (comment)
but the link says they are queued.
I suspect this is because of the time gap during the back-end switch.

[smuzaffar]

comparison results are now available

On 6/3/2015 6:06 PM, Slava Krutelyov wrote:

@smuzaffar https://github.com/smuzaffar please check the cms-bot
status in this case
the comparisons are supposedly ready
#9362 (comment)
#9362 (comment)
but the link says they are queued.
I suspect this is because of the time gap during the back-end switch.

—
Reply to this email directly or view it on GitHub
#9362 (comment).

[slava77]

+1

for #9362 5b86426

• changes in the code are OK, although I didn't check if in all cases it's an explicit duplicate or a case of wildcard selection
• jenkins tests passed and comparisons with baseline showed no difference as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlt]

It should be explicit, from what I see ROOT6 does not check between name and pattern based selection rules for duplicate check. Thus it only checks for duplicates between name based selection rules. Could check the ROOT code if needed.

[davidlange6]

+1