Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leading whitespace from types in classes_*def.xml selection files #9403

Merged
merged 1 commit into from
Jun 3, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jun 2, 2015

Trailing or leading whitespace could create problems for ROOT6
genreflex.

E.g., AnalysisDataFormats/TrackInfo

Warning - unused class rule: reco::TrackingStateInfo

ROOT6 couldn't get a match because of leading whitespace.

ROOT5 compatibility was restored at ROOT6 commit:
c7f7ef9160b833c799f398154ef16c5fd1c34313

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

Trailing or leading whitespace could create problems for ROOT6
genreflex.

E.g., `AnalysisDataFormats/TrackInfo`

    Warning - unused class rule: reco::TrackingStateInfo

ROOT6 couldn't get a match because of leading whitespace.

ROOT5 compatibility was restored at ROOT6 commit:
c7f7ef9160b833c799f398154ef16c5fd1c34313

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@davidlt
Copy link
Contributor Author

davidlt commented Jun 2, 2015

Have not yet tested, but seems that I haven't changed anything except whitespace. Will trigger Jenkins test job in case.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2015

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

Remove leading whitespace from types in classes_*def.xml selection files

It involves the following packages:

AnalysisDataFormats/TrackInfo
DataFormats/CaloTowers
DataFormats/EcalDetId
DataFormats/EcalDigi
DataFormats/EgammaCandidates
DataFormats/JetReco
DataFormats/L1GlobalTrigger
DataFormats/L1Trigger
DataFormats/METReco
DataFormats/ParticleFlowCandidate
DataFormats/ParticleFlowReco
DataFormats/Provenance
DataFormats/RPCDigi
DataFormats/SiPixelDigi
DataFormats/TauReco
DataFormats/TrackReco
DataFormats/VertexReco
FastSimDataFormats/NuclearInteractions
SimDataFormats/CaloHit

@civanch, @Dr15Jones, @lveldere, @cvuosalo, @ssekmen, @mdhildreth, @monttj, @cmsbuild, @slava77, @vadler, @mulhearn can you please review it and eventually sign? Thanks.
@rappoccio, @Sam-Harper, @jdolen, @wmtan, @makortel, @mmarionncern, @TaiSakuma, @wddgit, @lgray, @ahinzmann, @nhanvtran, @VinInn, @gpetruc, @schoef, @argiro, @jpavel, @mariadalfonso, @bachtis, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Jun 3, 2015

+1

For #9403 9e817a6

Purely technical change of deleting unneeded white space that was causing errors with ROOT6. Program behavior should not change.

Jenkins tests against baseline CMSSW_7_5_X_2015-06-02-1100 show no significant differences, as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants