-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove leading whitespace from types in classes_*def.xml selection files #9403
Remove leading whitespace from types in classes_*def.xml selection files #9403
Conversation
Trailing or leading whitespace could create problems for ROOT6 genreflex. E.g., `AnalysisDataFormats/TrackInfo` Warning - unused class rule: reco::TrackingStateInfo ROOT6 couldn't get a match because of leading whitespace. ROOT5 compatibility was restored at ROOT6 commit: c7f7ef9160b833c799f398154ef16c5fd1c34313 Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Have not yet tested, but seems that I haven't changed anything except whitespace. Will trigger Jenkins test job in case. |
A new Pull Request was created by @davidlt for CMSSW_7_5_X. Remove leading whitespace from types in classes_*def.xml selection files It involves the following packages: AnalysisDataFormats/TrackInfo @civanch, @Dr15Jones, @lveldere, @cvuosalo, @ssekmen, @mdhildreth, @monttj, @cmsbuild, @slava77, @vadler, @mulhearn can you please review it and eventually sign? Thanks. |
Remove leading whitespace from types in classes_*def.xml selection files
Trailing or leading whitespace could create problems for ROOT6
genreflex.
E.g.,
AnalysisDataFormats/TrackInfo
ROOT6 couldn't get a match because of leading whitespace.
ROOT5 compatibility was restored at ROOT6 commit:
c7f7ef9160b833c799f398154ef16c5fd1c34313
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch